Added ratelimit headers as class properties#57
Open
riquedev wants to merge 3 commits intoOpenCageData:masterfrom
Open
Added ratelimit headers as class properties#57riquedev wants to merge 3 commits intoOpenCageData:masterfrom
riquedev wants to merge 3 commits intoOpenCageData:masterfrom
Conversation
Member
|
Exposing the limits to the developer makes sense but I'm not sure yet his approach is the best to understand. The usage resets (at that timestamp), users might up- or downgrade in the meantime. What could work better is to have a method Would that work for you? I can move the code around a bit.
Free trial plans have rate limit data included, so do one-time plans. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added three new properties to the OpenCageGeocode class:
These properties are initialized as None and are populated based on the API response headers. To prevent the code from breaking if the headers are missing or renamed, I implemented the following logic:
Motivation:
I needed to capture this information in another project where I use this package. Since I’m currently not on the paid plan, the rate limit data is not included in the response. However, I thought it would be useful to have these properties available for potential future use if this data becomes available.
Tests:
I added simple tests for these new properties in the test/test_ratelimit_properties.py file to ensure that the changes work as expected.